Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - BuiltinPrograms #31324

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Apr 24, 2023

Problem

There are currently three structs for built-in programs:

  • solana_rbpf::vm::BuiltInProgram
  • solana_program_runtime::invoke_context::BuiltinProgram
  • solana_runtime::builtins::Builtin

This PR aims to unify the second and the third.

Summary of Changes

  • Moves BuiltinProgram of the program runtime into its own file.
  • Unifies the runtimes Builtin and program runtimes BuiltinProgram definitions.
  • Moves BuiltinPrograms from bank.rs into the program runtime.

@Lichtso Lichtso force-pushed the refactor/builtin_programs branch 5 times, most recently from f39000f to e1eb21d Compare April 24, 2023 14:10
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #31324 (f5c0e4e) into master (cece64d) will decrease coverage by 0.1%.
The diff coverage is 73.8%.

@@            Coverage Diff            @@
##           master   #31324     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         733      734      +1     
  Lines      207071   207090     +19     
=========================================
+ Hits       168910   168915      +5     
- Misses      38161    38175     +14     

@Lichtso Lichtso requested a review from pgarg66 April 24, 2023 15:41
@Lichtso Lichtso merged commit 4b0e16d into solana-labs:master Apr 24, 2023
@Lichtso Lichtso deleted the refactor/builtin_programs branch April 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants