Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a second level cache to contain tx batch specific programs #31413

Merged
merged 3 commits into from
May 1, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Apr 28, 2023

Problem

Program management instructions could potentially modify loaded programs by redeployment or closing. Having a separate data structure to contain transaction batch specific loaded program will simplify the code.

Summary of Changes

Add a second level cache to store transaction batch specific program entries. This cache can contain only one program for a given key, that's visible at a given slot. The program management instruction will replace the program entry if the program gets modified.

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso April 28, 2023 22:49
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #31413 (299962a) into master (117a194) will decrease coverage by 0.1%.
The diff coverage is 78.5%.

@@            Coverage Diff            @@
##           master   #31413     +/-   ##
=========================================
- Coverage    81.4%    81.4%   -0.1%     
=========================================
  Files         731      731             
  Lines      208501   208521     +20     
=========================================
- Hits       169787   169784      -3     
- Misses      38714    38737     +23     

@pgarg66 pgarg66 requested a review from Lichtso May 1, 2023 14:48
@pgarg66 pgarg66 merged commit 8eebf64 into solana-labs:master May 1, 2023
@pgarg66 pgarg66 deleted the batch-specific-cache branch May 1, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants