-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds quic receiver to shred-fetch-stage #31576
adds quic receiver to shred-fetch-stage #31576
Conversation
dcf8b91
to
f496609
Compare
is this something that can wait for 1.16 to be cut? really need to keep branch diffs to a minimum for the time being |
I actually need this to be deployed to testnet asap, |
Can I have this reviewed/merged? Also these PRs only add a code-path which is inactive for all shreds. The goal is to incrementally rollout and monitor for small percent of shreds on testnet and debug/optimize based on the outcome. |
f496609
to
9e50f09
Compare
Codecov Report
@@ Coverage Diff @@
## master #31576 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 763 763
Lines 207690 207735 +45
=======================================
+ Hits 170067 170156 +89
+ Misses 37623 37579 -44 |
9e50f09
to
bf3ea4b
Compare
we teed this feature set up for discussion on the thursday priorities call. general consensus today was that holding quic turbine for 1.16 would fair better for 1.16 stabilization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code looks good. I see merit to Trent's point about not wanting to introduce more changes between v1.14 and v1.16 given the already massive diff between the two. However, I also see merit to Behzad's point about wanting to get some basic plumbing in to build on top of to enable initial testing without having to deal with rebase hell later.
In order to try to meet in the middle, maybe something like a5f290a would be agreeable? That is, push the code in but not explicitly spawn the server by default for now.
We actually need to start testing QUIC on testnet for propagating a small percentage of slots. |
bf3ea4b
to
cbe11bd
Compare
f6bbde1
to
cf04b6a
Compare
Working towards migrating turbine to QUIC.
cf04b6a
to
9cb1fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With v1.16 branch cut, I believe we're good to go on these.
I see there have been some conversations in Discord and a SIMD, but assuming you're looking to push this in and test in parallel while those get hashed out ?
Working towards migrating turbine to QUIC.
Working towards migrating turbine to QUIC.
Working towards migrating turbine to QUIC.
Working towards migrating turbine to QUIC.
Problem
Working towards migrating turbine to QUIC.
Summary of Changes
Added QUIC receiver to shred-fetch-stage.