Add better hostname support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kevy0915
added a commit
to kevy0915/staking-ui
that referenced
this pull request
Sep 23, 2024
…e-support Add better hostname support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updated README for config options to adding a pool, and also specific instructions for adding a custom hostname
This uses some nextJS rewrite magic. Unfortunately it has 2 shortcomings which is the domain HAS to add your pools name on the path, it will not allow for rewriting
/so there is both a rewrite and redirect rule added. In addition nextJS support for importing a ESM module into next.config.js does not work so right now you have to take 1 extra step to define the hostname mapping. Eventually we will figure out a way to have all pool config in one place