Generic correct merging of local params

[thomascorthals]

I took the idea from #937 and applied it to AbstractRequestBuilder::renderLocalParams() instead. That should catch all cases where a user puts local params in a query and we try to add more in our code.

I hit a snag with converting code that uses LocalParameters::render() though and I would like feedback from @wickedOne. The way parameters are stored and rendered within LocalParameters isn't compatible with the key => value array renderLocalParams() expects. I have included a kludge to parse them into such an array for now as a proof-of-concept. It works as expected: all tests pass and the output from the examples is identical.

Would it be ok to remove LocalParameters::render() completely? Or does it add something that I'm missing?

---

Also added array support to Helper::qparser() so it handles ['excludeTags' => ['tag1', 'tag2']] the same way as AbstractRequestBuilder::renderLocalParams() does.

[codecov]

Codecov Report

Merging #939 (82b6319) into master (08b839f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   92.60%   92.62%   +0.01%     
==========================================
  Files         334      334              
  Lines        8223     8243      +20     
==========================================
+ Hits         7615     7635      +20     
  Misses        608      608              

Flag	Coverage Δ
unittests	92.62% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Component/RequestBuilder/FacetSet.php	100.00% <100.00%> (ø)
src/Component/RequestBuilder/Stats.php	100.00% <100.00%> (ø)
src/Component/RequestBuilder/SubRequest.php	75.00% <100.00%> (ø)
src/Core/Query/AbstractRequestBuilder.php	100.00% <100.00%> (ø)
src/Core/Query/Helper.php	100.00% <100.00%> (ø)
src/Core/Query/LocalParameters/LocalParameters.php	100.00% <100.00%> (ø)
src/QueryType/Select/RequestBuilder.php	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b839f...82b6319. Read the comment docs.

[mkalkbrenner]

The patch looks good to me.

[mkalkbrenner]

@wickedOne @thomascorthals Should I merge the PR as it is or should we wait for another review?

[thomascorthals]

@mkalkbrenner I still had to remove LocalParameters::render() but that meant rewriting all the unit tests for LocalParameters. I wanted to be sure it was worth the effort first. 😉 Also cleaned up the code to get the actual parameters for rendering, my POC used a kludge for that.

Noticed that booleans weren't yet converted to 'true' and 'false' and that 0 wouldn't be rendered while it is a valid value. Fixed those as well.