Support ESM configs #189
Merged
Support ESM configs #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* eslint-disable-next-line @typescript-eslint/no-var-requires */ | ||
| const required: unknown = require(file) | ||
|
|
||
| const fakeEsmDefaultExport = |
There was a problem hiding this comment.
When TypeScript exports to CommonJS format it translates export default to a fake default like this, even though the format doesn't have that concept
tammy-baylis-swi
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ESM projects could not use a JS config file because the loading code was always synchronous and always used
required. Now it will be synchronous only when it needs to be and use dynamic asynchronousimportotherwise