-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token bucket and dice + test runner fixes #278
Conversation
const { devDependencies } = JSON.parse( | ||
await readFile("package.json", { encoding: "utf-8" }), | ||
) as { devDependencies: Record<string, string> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing from package.json
caused some issues with ESM on recent Node versions in tests, this works the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments.
The PR looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ship it!
This adds token bucket and dice implementations for sampling, and updates the test runner as its coverage reports were broken. Additional info in comments.