Applied the feedback from community to our extension #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swi-jared
reviewed
May 14, 2024
|
|
||
| type Config struct { | ||
| Endpoint string `mapstructure:"endpoint"` | ||
| Key string `mapstructure:"key"` | ||
| Interval time.Duration `mapstructure:"interval"` | ||
| } | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Do these consts need to be public? If not, I'd make them private by lower-casing the first letter.
There was a problem hiding this comment.
Yes, all examples from otel collector & otel collector contrib repo are in capital letter
swi-jared
approved these changes
May 14, 2024
| } | ||
|
|
||
| func resolveServiceNameBestEffort() string { | ||
| if otelServiceName, otelServiceNameDefined := os.LookupEnv("OTEL_SERVICE_NAME"); otelServiceNameDefined && len(otelServiceName) > 0 { |
There was a problem hiding this comment.
Idiomatically, it's OK to use and re-use names. For this and the similar version below I'd stick with if name, ok :=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the PR feedback from community to our extension.