Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BusyBox ls format support #11

Closed
wants to merge 3 commits into from
Closed

Conversation

mkowalczuk
Copy link

It should resolve #6

I've tested it on on HTC Desire with CyanogenMod 7.1 (BusyBox v1.19.1-cm71 bionic (2011-09-01 04:24 +0200) multi-call binary.)

Some unofficial ROMs (eg. CyanogenMod) come with BusyBox instead of generic
ls. Their output is different.
@sole
Copy link
Owner

sole commented Mar 14, 2012

I'm merging these, will push the merged version today or tomorrow. Thanks :)

@sole
Copy link
Owner

sole commented Mar 14, 2012

Merged! If you have any spare moment it'd be great if you could download the latest version and test it works with your Cyanogen device, as I don't have any running CM... :-)

@sole sole closed this Mar 14, 2012
@mkowalczuk
Copy link
Author

On 14.03.2012 23:30, sole wrote:

Merged! If you have any spare moment it'd be great if you could download the latest version and test it works with your Cyanogen device, as I don't have any running CM... :-)

Works fine, although you can add a comment to your docs regarding LC_TIME:

I had a problem with Android's ls returning time in C locale format and
your script (running on my machine with LC_TIME set to my local
pl_PL.UTF-8) tried to parse it expecting Polish weekday/month names.
That obviously failed. As a workaround I have to run aafm like this:
LC_TIME=C ./aafm-gui.py

best regards,
Michał Kowalczuk
https://kowalczuk.eu/

@sole
Copy link
Owner

sole commented Mar 19, 2012

Oh that's quite an interesting point to make, and I would have never noticed as I use Linux in English. I'll see whether I can force using LC_TIME C from within the script instead of requiring the user to assign the env value before launching.

Many thanks!

@mkowalczuk
Copy link
Author

You're right, setting it is probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls parsing
2 participants