Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and improvements #59

Merged
merged 14 commits into from
Sep 30, 2014
Merged

Various fixes and improvements #59

merged 14 commits into from
Sep 30, 2014

Conversation

thp
Copy link
Contributor

@thp thp commented Sep 26, 2014

Sorry for just having a single big pull request, if you want to have some commits singled out as separate pull request, I can do that (just tell me which ones you want).

This basically gives you:

  • Update the UI at least after each file (process events)
  • Better running of processes (and parsing their output), no need to use the shell or quoting
  • Make the task queue FIFO (was LIFO)
  • Only create directory on the device when needed
  • Recursive copying and deletion should do proper progress reporting
  • Fix panels paned width calculation (was wrong for me on Fedora 20)
  • Don't re-implemented "copy to computer" logic for the context menu
  • Use a Gtk main menu instead of a single checkbox (for hidden files)
  • Support for having multiple devices connected (+GUI for selecting)
  • Show free disk space of current directory on device
  • Refresh device list menu item, and "no devices found" handling

I didn't take too much care about making sure this works on Windows as well (device path handling), that could be done, but haven't gotten around to doing it yet (just scratching an itch here).

Ideally I'd like to see all commands being run in a separate thread, so that the UI never blocks. And while there's no progress indication for long-running adb push/pull commands (e.g. pushing or pulling a 50 MiB file), it might be nice to parse adb's output, remember the "best" transfer rate for the device in the session and then based on file size and expected transfer rate, come up with a way to display "in-file" progress. This is not perfect, but might make the experience better (well, faking fine-grained progress information) than just updating the progress bar after every file.

@sole
Copy link
Owner

sole commented Sep 27, 2014

Woa. This looks super awesome O_O

Let me test it and I'll merge it as soon as possible :)

Many thanks!! 👍

@cb474
Copy link

cb474 commented Sep 29, 2014

Hey thp, I'm just an end user, but thanks for providing so many useful improvements to aafm. I look forward to seeing them merged. I use it all the time and it's great to have improvements to the project. It has saved me from the terrible days of MTP. And thanks, of course, sole for creating and maintaining aafm.

sole added a commit that referenced this pull request Sep 30, 2014
Various fixes and improvements
@sole sole merged commit 67fa624 into sole:master Sep 30, 2014
@sole
Copy link
Owner

sole commented Sep 30, 2014

Wow, tried this and merged it immediately!

Mega awesome! \o/ Thanks! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants