-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and improvements #59
Conversation
This isn't ideal, as recursive directory copying isn't exposed as per-item progress, but this can be fixed later.
When /mnt/sdcard is a symlink, checking if /mnt/sdcard/DCIM (for example) is a directory must list "/mnt/sdcard/", not "/mnt/sdcard".
Woa. This looks super awesome O_O Let me test it and I'll merge it as soon as possible :) Many thanks!! 👍 |
Hey thp, I'm just an end user, but thanks for providing so many useful improvements to aafm. I look forward to seeing them merged. I use it all the time and it's great to have improvements to the project. It has saved me from the terrible days of MTP. And thanks, of course, sole for creating and maintaining aafm. |
Wow, tried this and merged it immediately! Mega awesome! \o/ Thanks! \o/ |
Sorry for just having a single big pull request, if you want to have some commits singled out as separate pull request, I can do that (just tell me which ones you want).
This basically gives you:
I didn't take too much care about making sure this works on Windows as well (device path handling), that could be done, but haven't gotten around to doing it yet (just scratching an itch here).
Ideally I'd like to see all commands being run in a separate thread, so that the UI never blocks. And while there's no progress indication for long-running adb push/pull commands (e.g. pushing or pulling a 50 MiB file), it might be nice to parse adb's output, remember the "best" transfer rate for the device in the session and then based on file size and expected transfer rate, come up with a way to display "in-file" progress. This is not perfect, but might make the experience better (well, faking fine-grained progress information) than just updating the progress bar after every file.