New addition in the test-suite panel \o/ #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome @bourgeoa! As you may have seen [on Gitter](https://gitter.im/solid/test-suite?at=601be7ec428d9727dd54c7cc), Alain updated both NSS and the test suite to fix all the failing tests there, making NSS the second implementation of Solid that passes all 164 tests in the test suite. Please approve/reject Alain's candidature by approving (or not) this PR.
|
@timbl @justinwb @jaxoncreed ping |
|
Note that Alain was already added to the github team but someone still needs to click 'merge' on this PR. |
justinwb
approved these changes
Feb 22, 2021
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome @bourgeoa!
As you may have seen on Gitter, Alain updated both NSS and the test suite to fix all the failing tests there, making NSS the second implementation of Solid that passes all 164 tests in the test suite.
Please approve/reject Alain's candidature by approving (or not) this PR.
I also moved our Gitter channel to the top in the list of communication channels.