Remove support for TLS mode #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authType field indicated whether TLS or OIDC was used. Since d45b7b6 removed TLS, auth is necessarily OIDC.
timbl
approved these changes
Jul 16, 2018
RubenVerborgh
force-pushed
the
fix/remove-webid-tls
branch
from
b6c3892 to
ba30fab
Compare
This was referenced Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running node-solid-server in TLS mode is deprecated (nodeSolidServer/node-solid-server#667), and the auth client does not work with it (#44, #47).
Therefore, this PR removes support for TLS mode.
Closes #44, #47.