added uniChamfer[X] and improved addHullStep to work on subtracting

solidboredom · solidboredom · commit 35732620d8aa · 2025-04-03T21:23:12.000+02:00
diff --git a/cad_kickstart/constructive-compiled.scad b/cad_kickstart/constructive-compiled.scad
@@ -1092,8 +1092,8 @@ module assemble(
 
 module addHullStep(onlyFor=currentPart(),addOnly=true,removeOnly=false)
 {
-  if(!(addOnly && $removing) && 
-  	  !(removeOnly && !$removing) && 
+  if((removeOnly ||!(addOnly && $removing)) && 
+  	  !(removeOnly && $removing) && 
   		partIs(onlyFor)) hull()
     {
        $hulling=true;
@@ -1404,6 +1404,28 @@ function chamferOff()=chamfer(disable=true);
 function chamferOn()=chamfer(disable=false);
 
 
+function uniChamfer4(bot, top, insideBot, insideTop, side, fnCorner=7, sideDiff=($skinThick*2) ) = 
+			$removing
+			?chamfer(insideBot, insideTop, side?( side-($skinThick*2)):undef,fnCorner = fnCorner)
+			:chamfer(bot,top,
+						side,	fnCorner = fnCorner);
+
+function uniChamfer2(bot, top, side, fnCorner=7 ,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-bot,-top, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( bot, top, side, fnCorner=fnCorner);
+
+function uniChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-botTop,-botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side               ,fnCorner = fnCorner);
+
+function equiChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer( botTop, botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side         ,fnCorner = fnCorner);
+
+
 //skin functions to create Skins for Objects
 
 $skinThick=1.5; //default wall Thickness for Skins is set to 1.5 mm
diff --git a/constructive-compiled.scad b/constructive-compiled.scad
@@ -1092,8 +1092,8 @@ module assemble(
 
 module addHullStep(onlyFor=currentPart(),addOnly=true,removeOnly=false)
 {
-  if(!(addOnly && $removing) && 
-  	  !(removeOnly && !$removing) && 
+  if((removeOnly ||!(addOnly && $removing)) && 
+  	  !(removeOnly && $removing) && 
   		partIs(onlyFor)) hull()
     {
        $hulling=true;
@@ -1404,6 +1404,28 @@ function chamferOff()=chamfer(disable=true);
 function chamferOn()=chamfer(disable=false);
 
 
+function uniChamfer4(bot, top, insideBot, insideTop, side, fnCorner=7, sideDiff=($skinThick*2) ) = 
+			$removing
+			?chamfer(insideBot, insideTop, side?( side-($skinThick*2)):undef,fnCorner = fnCorner)
+			:chamfer(bot,top,
+						side,	fnCorner = fnCorner);
+
+function uniChamfer2(bot, top, side, fnCorner=7 ,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-bot,-top, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( bot, top, side, fnCorner=fnCorner);
+
+function uniChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-botTop,-botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side               ,fnCorner = fnCorner);
+
+function equiChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer( botTop, botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side         ,fnCorner = fnCorner);
+
+
 //skin functions to create Skins for Objects
 
 $skinThick=1.5; //default wall Thickness for Skins is set to 1.5 mm
diff --git a/examples/constructive-compiled.scad b/examples/constructive-compiled.scad
@@ -1092,8 +1092,8 @@ module assemble(
 
 module addHullStep(onlyFor=currentPart(),addOnly=true,removeOnly=false)
 {
-  if(!(addOnly && $removing) && 
-  	  !(removeOnly && !$removing) && 
+  if((removeOnly ||!(addOnly && $removing)) && 
+  	  !(removeOnly && $removing) && 
   		partIs(onlyFor)) hull()
     {
        $hulling=true;
@@ -1404,6 +1404,28 @@ function chamferOff()=chamfer(disable=true);
 function chamferOn()=chamfer(disable=false);
 
 
+function uniChamfer4(bot, top, insideBot, insideTop, side, fnCorner=7, sideDiff=($skinThick*2) ) = 
+			$removing
+			?chamfer(insideBot, insideTop, side?( side-($skinThick*2)):undef,fnCorner = fnCorner)
+			:chamfer(bot,top,
+						side,	fnCorner = fnCorner);
+
+function uniChamfer2(bot, top, side, fnCorner=7 ,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-bot,-top, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( bot, top, side, fnCorner=fnCorner);
+
+function uniChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-botTop,-botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side               ,fnCorner = fnCorner);
+
+function equiChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer( botTop, botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side         ,fnCorner = fnCorner);
+
+
 //skin functions to create Skins for Objects
 
 $skinThick=1.5; //default wall Thickness for Skins is set to 1.5 mm
diff --git a/kickstart.zip b/kickstart.zip
diff --git a/sources/assemble.scad b/sources/assemble.scad
@@ -195,8 +195,8 @@ module assemble(
 
 module addHullStep(onlyFor=currentPart(),addOnly=true,removeOnly=false)
 {
-  if(!(addOnly && $removing) && 
-  	  !(removeOnly && !$removing) && 
+  if((removeOnly ||!(addOnly && $removing)) && 
+  	  !(removeOnly && $removing) && 
   		partIs(onlyFor)) hull()
     {
        $hulling=true;
diff --git a/sources/constructive.scad b/sources/constructive.scad
@@ -137,6 +137,28 @@ function chamferOff()=chamfer(disable=true);
 function chamferOn()=chamfer(disable=false);
 
 
+function uniChamfer4(bot, top, insideBot, insideTop, side, fnCorner=7, sideDiff=($skinThick*2) ) = 
+			$removing
+			?chamfer(insideBot, insideTop, side?( side-($skinThick*2)):undef,fnCorner = fnCorner)
+			:chamfer(bot,top,
+						side,	fnCorner = fnCorner);
+
+function uniChamfer2(bot, top, side, fnCorner=7 ,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-bot,-top, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( bot, top, side, fnCorner=fnCorner);
+
+function uniChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer(-botTop,-botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side               ,fnCorner = fnCorner);
+
+function equiChamfer(botTop,side,fnCorner=7,sideDiff=($skinThick*2)) = 
+			$removing
+			?chamfer( botTop, botTop, side-sideDiff,fnCorner = fnCorner)
+			:chamfer( botTop, botTop, side         ,fnCorner = fnCorner);
+
+
 //skin functions to create Skins for Objects
 
 $skinThick=1.5; //default wall Thickness for Skins is set to 1.5 mm

Original file line number	Diff line number	Diff line change
`@@ -195,8 +195,8 @@ module assemble(`
`195`	`195`
`196`	`196`	`module addHullStep(onlyFor=currentPart(),addOnly=true,removeOnly=false)`
`197`	`197`	`{`
`198`		`- if(!(addOnly && $removing) &&`
`199`		`- !(removeOnly && !$removing) &&`
	`198`	`+ if((removeOnly \|\|!(addOnly && $removing)) &&`
	`199`	`+ !(removeOnly && $removing) &&`
`200`	`200`	`partIs(onlyFor)) hull()`
`201`	`201`	`{`
`202`	`202`	`$hulling=true;`