Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lit: classList wierd behavior for dynamic key #443

Closed
codart1 opened this issue May 8, 2021 · 1 comment
Closed

lit: classList wierd behavior for dynamic key #443

codart1 opened this issue May 8, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@codart1
Copy link

codart1 commented May 8, 2021

Describe the bug
I made a small sandbox that reproduces the issue here: https://codesandbox.io/s/solid-class-list-bug-otwqz

Try to click the button a few times and observe that the output classes are incorrect. It should only be haha foo or haha bar. Not haha foo bar.

@ryansolid ryansolid changed the title classList wierd behavior for dynamic key lit: classList wierd behavior for dynamic key May 8, 2021
@ryansolid
Copy link
Member

I see it. I'm not passing previous values into classList or styles bindings in the lit version of Solid.

@ryansolid ryansolid added the bug Something isn't working label May 8, 2021
@ryansolid ryansolid added this to the 1.0.0 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants