Prep for Solidus 4+ #114
Merged
Prep for Solidus 4+ #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelargir
force-pushed
the
solidus-4-0
branch
8 times, most recently
from
f36b942
to
125b02c
Compare
Result of running `bundle exec solidus extension .` and remitting overwrites
pelargir
force-pushed
the
solidus-4-0
branch
2 times, most recently
from
460a55c
to
ebe59a0
Compare
When uploading images, the first image in the list was empty. This caused a message encryption error. Unsure why the spec is passing an empty image ahead of a real one, but we can bypass empty images easily enough which fixes the problem.
kennyadsl
approved these changes
Jun 20, 2023
|
Thanks! v1.6.0 released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets this extension working with Solidus 4+