Fix gem version comparison #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we transformed the gem version to a float because we wanted to compare numbers. That was causing an issue with 0-ending strings. For example, `"2.10".to_f` will be transformed into `2.1` float number. This commit solves the issue comparing Gem::Version.
MassimilianoLattanzio
requested review from
DanielePalombo,
abhishekgupta5 and
piyushswain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we transformed the gem version to a float because we wanted to compare numbers.
That was causing an issue with 0-ending strings.
For example,
"2.10".to_fwill be transformed into2.1float number.This PR solves the issue comparing Gem::Version.