Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaxRate M-M TaxCategory #1851

Merged
merged 4 commits into from
May 23, 2017
Merged

TaxRate M-M TaxCategory #1851

merged 4 commits into from
May 23, 2017

Commits on May 23, 2017

  1. Temporarily disable specs that create TaxRates 

    solidusio#1851 will change the
type of relation to a many to many so specs will temporarily need to
be skipped until changes are made to the specs.
    @vladstoick
    vladstoick committed May 23, 2017
    Configuration menu
    Copy the full SHA
    ed0fd82 View commit details
    Browse the repository at this point in the history

  2. Migrate TaxRate, TaxCategory relation to a M-M 

    Implements solidusio#1836

The current relation between TaxRate and TaxCategory can lead
to unnecessary tax rates if a store has multiple tax categories
and if it supports countries (such as Australia) that have a
standard tax rate. This means that for each TaxCategory, the store
will have an extra tax rate even if the percent is the same.

By transforming this relation to a M-M we can allow stores to
create tax rates that have multiple tax categories.
    @vladstoick
    vladstoick committed May 23, 2017
    Configuration menu
    Copy the full SHA
    c0f8394 View commit details
    Browse the repository at this point in the history

  3. Re-enable specs that create tax rates 

    Specs have been disabled until changes to the relation between
TaxRate and TaxCategory have been updated.
    @vladstoick
    vladstoick committed May 23, 2017
    Configuration menu
    Copy the full SHA
    1c5c5de View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG with TaxRate<->TaxCategory change

    @vladstoick
    vladstoick committed May 23, 2017
    Configuration menu
    Copy the full SHA
    8033843 View commit details
    Browse the repository at this point in the history