Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace skeleton grid with bootstrap grid #2767

Closed
wants to merge 2 commits into from
Closed

Replace skeleton grid with bootstrap grid #2767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec07a3
remove _skeleton.scss and add bootstrap-grid.css
jacobherrington Jun 7, 2018
7c2c35d
Take out instances of Skeleton CSS in frontend
Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,14 @@ This will copy all views whose directory or filename contains the string "produc

### Handle upgrades

After upgrading solidus to a new version run the generator again and follow on screen instructions.
After upgrading Solidus to a new version run the generator again and follow on screen instructions.

## Testing

Run the tests

bundle exec rspec

## Included CSS

Solidus frontend does not support a CSS framework out-of-the-box. Custom styles can be found in `app/assets/stylesheets/spree/frontend/screen.css.scss`. We have also included the grid system from Bootstrap 4.1.1 in `app/assets/stylesheets/spree/frontend/bootstrap-grid.css`.
242 changes: 0 additions & 242 deletions frontend/app/assets/stylesheets/spree/frontend/_skeleton.scss
View file
Open in desktop

This file was deleted.

Loading