Reuse Stripe profiles when customer adds a new credit card

[spaghetticode]

When a Spree::User adds a new credit card and that user already has a saved credit card stored we should reuse their existing Stripe customer profile instead of creating a new one.

This is a screenshot from a Stripe test account that shows a single email address with 3 different customer accounts, each with one single credit card:

This can be surely done when using the Stripe official gem, but we need to investigate if ActiveMerchant allows this.

[brchristian]

We are looking at building out a subscription implementation on top of solidus_stripe, and persistent customer accounts are a critical first step, so adding a +1 to this. LMK if I can help with a PR...

[brchristian]

It seems to me that in an ideal world, this extension would include a migration to add a stripe_gateway_customer_id to the Spree::Users table.

But, maybe there's another way to do it. When creating a new Spree::CreditCard object, we can attempt to populate the gateway_customer_id field like so:

gateway_customer_profile_id = source.user&.
payment_sources&.where&.not(gateway_customer_profile_id: nil)&.order(:updated_at)&.last&.
gateway_customer_profile_id

@spaghetticode What do you think about trying something like that?

[brchristian]

Updating with two pieces of information. First is that I've created a (failing) spec at #77 to demonstrate this issue.

Second is that I have begun tracking down the cause. I believe the key lines are here:

solidus_stripe/app/models/spree/payment_method/stripe_credit_card.rb

Lines 122 to 139 in eca6dc2

	response = gateway.store(creditcard, options)
	if response.success?
	if v3_intents?
	payment.source.update!(
	cc_type: payment.source.cc_type,
	gateway_customer_profile_id: response.params['customer'],
	gateway_payment_profile_id: response.params['id']
	)
	else
	payment.source.update!(
	cc_type: payment.source.cc_type,
	gateway_customer_profile_id: response.params['id'],
	gateway_payment_profile_id: response.params['default_source'] || response.params['default_card']
	)
	end
	else
	payment.send(:gateway_error, response.message)
	end

Here you can see how we're setting the gateway_customer_profile_id. Of course, a trivial way to make the specs in #77 pass would be to change the lines that directly update the payment source, but this would not be sufficient because the data would look right to Solidus and in the database, but would not actually be correct in Stripe.

It seems that we need to link this to the customer either before or during the call to gateway.store. This method lives in ActiveMerchant. So, I'll keep digging and update this thread when I learn more.

[brchristian]

Update: the specs are now green in #77, which should solve this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.