Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve_external_request_id #1875

Closed
sbvitok opened this issue Dec 10, 2019 · 2 comments
Closed

preserve_external_request_id #1875

sbvitok opened this issue Dec 10, 2019 · 2 comments

Comments

@sbvitok
Copy link

sbvitok commented Dec 10, 2019

Is your feature request related to a problem? Please describe.
I have Nginx as edge proxy with some lua code, and Gloo (Envoy) as kubernetes ingress on bare metal. I need to trace request from nginx to app, the problem is that Envoy and Nginx have different format of request id
Nginx:
X-Request-id: f5ae2621ffff2e7d5000bb8f04ef278a
Envoy:
X-Request-Id: fceb3265-4be8-45f0-b410-e4b5ccc39dd4
as a result envoy replaces old request id by new one generated.
Describe the solution you'd like
Add to the Gateway preserveExternalRequestId option in httpConnectionManagerSettings section which will enable envoy preserve_external_request_id option
@EItanya
Copy link
Member

EItanya commented Dec 12, 2019

Added here: #1907

soloio-bulldozer bot pushed a commit that referenced this issue Dec 12, 2019
@EItanya @soloio-bulldozer
#1875 preserve_external_request_id (#1907)
de220e6 
* added hcm field
* changelog
@EItanya EItanya closed this as completed Dec 12, 2019
@sbvitok
Copy link
Author

sbvitok commented Dec 13, 2019

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EItanya @sbvitok