Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3833
Description
Route replacement with
UpstreamGroups
does not work, allowing invalid config being sent to envoy.Specifically, when route replacement is enabled and a route references a missing
UpstreamGroup
, an envoyRoute
will be served which does not contain a destination cluster of any type.This change ensures that the route which points to a missing
UpstreamGroup
will be considered for when route replacement occurs.Context
This bug is due to the fact that route replacement relies on the
ClusterSpecifier
of aRoute
being set, even if it references a missing or otherwise invalid cluster.It wasn't working because if an
UpstreamGroup
isn't found, we immediately return an error which means aClusterSpecifier
is not set on theRoute
, e.g. it isnil
Checklist:
make install-go-tools generated-code
to ensure there will be no code diffBOT NOTES:
resolves Route Replacement does not work with UpstreamGroups #3818