Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default GatewayParameters #9493

Merged
merged 66 commits into from
May 24, 2024
Merged

Default GatewayParameters #9493

merged 66 commits into from
May 24, 2024

Conversation

jbohanon
Copy link
Contributor

@jbohanon jbohanon commented May 16, 2024

Description

TODO:

  • e2e tests

Fill out any of the following sections that are relevant and remove the others

API changes

  • Added x field to y resource
  • ...

Code changes

  • Fix error in Foo() function
  • Add Bar() function
  • ...

CI changes

  • Adjusted schedule for x job
  • ...

Docs changes

  • Added guide about feature x to public docs
  • Updated README to account for y behavior
  • ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6113

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Visit the preview URL for this PR (updated for commit affbbb2):

https://gloo-edge--pr9493-jbohanon-default-gat-ph7stch4.web.app

(expires Thu, 30 May 2024 21:56:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@jbohanon jbohanon added the work in progress signals bulldozer to keep pr open (don't auto-merge) label May 16, 2024
pkg/utils/utils.go Outdated Show resolved Hide resolved
npolshakova
npolshakova previously approved these changes May 23, 2024
Copy link
Contributor

@jenshu jenshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will you add e2e tests in a follow-up PR?

projects/gateway2/deployer/values_helpers.go Show resolved Hide resolved
projects/gateway2/deployer/deployer_test.go Show resolved Hide resolved
@jenshu jenshu merged commit 33ff5e4 into main May 24, 2024
25 checks passed
@jenshu jenshu deleted the jbohanon/default-gatewayparameters branch May 24, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants