Doc fixes #9521

Nadine2016 · 2024-05-24T14:21:00Z

Description

Please include a high level summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Fill out any of the following sections that are relevant and remove the others

API changes

Added x field to y resource
...

Code changes

Fix error in Foo() function
Add Bar() function
...

CI changes

Adjusted schedule for x job
...

Docs changes

Added guide about feature x to public docs
Updated README to account for y behavior
...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works

github-actions · 2024-05-24T14:37:35Z

Visit the preview URL for this PR (updated for commit e11be95):

https://gloo-edge--pr9521-doc-fixes-hxtd2n5f.web.app

_{(expires Tue, 04 Jun 2024 14:32:04 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}

docs/content/installation/advanced_configuration/vault_secrets.md

docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md

docs/content/installation/advanced_configuration/vault_secrets.md

Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

…netes_services/_index.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Nadine2016 · 2024-05-28T13:31:28Z

/skip-ci

Nadine2016 · 2024-05-28T14:22:03Z

/skip-ci

* doc fixes for the week * clarification for kube services * remove note * version bumps * Rename doc-fixes.yaml to doc-fixes.yaml * update vault secrets * kube services clarifications * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update vault_secrets.md --------- Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

* hugo theme bump * istioIntegration.disableAutoinjection * Doc fixes for week of 2024-05-06 (#9475) * Add food bowl image * Add files via upload * Delete docs/content/img/portal/petstore-food-bowl.png * Transformation fixes * Revise how we describe OSS vs. EE See question in Slack: https://solo-io-corp.slack.com/archives/CEDCS8TAP/p1715012663208689 * update support number, see slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1715092657711459 * changelog * changelog * version bump * Update docs/content/introduction/faq.md Co-authored-by: Rachael Graham <rachael.graham@solo.io> --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> * Doc fixes (#9497) * Update automatic_discovery.md * changelog * version bump * changelog * changelog * Adding changelog file to new location * Deleting changelog file from old location * Doc fixes (#9521) * doc fixes for the week * clarification for kube services * remove note * version bumps * Rename doc-fixes.yaml to doc-fixes.yaml * update vault secrets * kube services clarifications * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update vault_secrets.md --------- Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * changelog --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

* hugo theme bump * istioIntegration.disableAutoinjection * Doc fixes for week of 2024-05-06 (#9475) * Add food bowl image * Add files via upload * Delete docs/content/img/portal/petstore-food-bowl.png * Transformation fixes * Revise how we describe OSS vs. EE See question in Slack: https://solo-io-corp.slack.com/archives/CEDCS8TAP/p1715012663208689 * update support number, see slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1715092657711459 * changelog * changelog * version bump * Update docs/content/introduction/faq.md --------- * Doc fixes (#9497) * Update automatic_discovery.md * changelog * version bump * changelog * changelog * Adding changelog file to new location * Deleting changelog file from old location * Doc fixes (#9521) * doc fixes for the week * clarification for kube services * remove note * version bumps * Rename doc-fixes.yaml to doc-fixes.yaml * update vault secrets * kube services clarifications * Update docs/content/installation/advanced_configuration/vault_secrets.md * Update docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md * Update docs/content/installation/advanced_configuration/vault_secrets.md * Update vault_secrets.md --------- * changelog --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

* [v1.13.x] Backport docs (#9499) * hugo theme bump * istioIntegration.disableAutoinjection * Doc fixes for week of 2024-05-06 (#9475) * Add food bowl image * Add files via upload * Delete docs/content/img/portal/petstore-food-bowl.png * Transformation fixes * Revise how we describe OSS vs. EE See question in Slack: https://solo-io-corp.slack.com/archives/CEDCS8TAP/p1715012663208689 * update support number, see slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1715092657711459 * changelog * changelog * version bump * Update docs/content/introduction/faq.md Co-authored-by: Rachael Graham <rachael.graham@solo.io> --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> * Doc fixes (#9497) * Update automatic_discovery.md * changelog * version bump * changelog * changelog * Adding changelog file to new location * Deleting changelog file from old location * Doc fixes (#9521) * doc fixes for the week * clarification for kube services * remove note * version bumps * Rename doc-fixes.yaml to doc-fixes.yaml * update vault secrets * kube services clarifications * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update docs/content/installation/advanced_configuration/vault_secrets.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Update vault_secrets.md --------- Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * changelog --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * rev istio --------- Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Rachael Graham <rachael.graham@solo.io> Co-authored-by: Nadine Spies <nadine.spies@solo.io> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Nadine Spies added 4 commits May 23, 2024 14:16

doc fixes for the week

b179801

clarification for kube services

97c3f95

remove note

ef3ef40

version bumps

67915d4

Nadine2016 requested a review from a team as a code owner May 24, 2024 14:21

github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 24, 2024

Merge main into doc-fixes

7d2ec26

artberger previously approved these changes May 24, 2024

View reviewed changes

Rename doc-fixes.yaml to doc-fixes.yaml

f2b442a

Nadine2016 dismissed artberger’s stale review via f2b442a May 24, 2024 14:57

artberger previously approved these changes May 24, 2024

View reviewed changes

nfuden reviewed May 24, 2024

View reviewed changes

docs/content/installation/advanced_configuration/vault_secrets.md Outdated Show resolved Hide resolved

update vault secrets

969c617

Nadine2016 dismissed artberger’s stale review via 969c617 May 24, 2024 20:38

kube services clarifications

2760f21

jbohanon reviewed May 28, 2024

View reviewed changes

docs/content/guides/traffic_management/destination_types/kubernetes_services/_index.md Outdated Show resolved Hide resolved

jbohanon reviewed May 28, 2024

View reviewed changes

docs/content/installation/advanced_configuration/vault_secrets.md Outdated Show resolved Hide resolved

jbohanon reviewed May 28, 2024

View reviewed changes

docs/content/installation/advanced_configuration/vault_secrets.md Outdated Show resolved Hide resolved

jbohanon suggested changes May 28, 2024

View reviewed changes

docs/content/installation/advanced_configuration/vault_secrets.md Outdated Show resolved Hide resolved

Nadine2016 and others added 4 commits May 28, 2024 09:14

Update docs/content/installation/advanced_configuration/vault_secrets.md

47f87ff

Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Update docs/content/guides/traffic_management/destination_types/kuber…

40ff2c1

…netes_services/_index.md Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Update docs/content/installation/advanced_configuration/vault_secrets.md

d07d761

Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

Update vault_secrets.md

5333d53

artberger approved these changes May 28, 2024

View reviewed changes

Rachael-Graham approved these changes May 28, 2024

View reviewed changes

Nadine2016 enabled auto-merge (squash) May 28, 2024 13:31

Merge branch 'main' into doc-fixes

b4d7f88

jbohanon approved these changes May 28, 2024

View reviewed changes

Merge refs/heads/main into doc-fixes

e11be95

Nadine2016 merged commit 53f2eb8 into main May 28, 2024
24 checks passed

Nadine2016 deleted the doc-fixes branch May 28, 2024 14:22

artberger mentioned this pull request Jun 3, 2024

[v1.15.x] Backport docs (#9499) #9566

Merged

4 tasks

artberger mentioned this pull request Jun 3, 2024

[v1.14.x] Backport docs (#9499) #9567

Merged

4 tasks

artberger mentioned this pull request Jun 3, 2024

[v1.13.x] Backport docs (#9499) #9568

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc fixes #9521

Doc fixes #9521

Nadine2016 commented May 24, 2024

github-actions bot commented May 24, 2024 •

edited

Loading

Nadine2016 commented May 28, 2024

Nadine2016 commented May 28, 2024

Doc fixes #9521

Doc fixes #9521

Conversation

Nadine2016 commented May 24, 2024

Description

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

github-actions bot commented May 24, 2024 • edited Loading

Nadine2016 commented May 28, 2024

Nadine2016 commented May 28, 2024

github-actions bot commented May 24, 2024 •

edited

Loading