Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update how kube2e tests report and update the glooctl check tests #9634

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

nfuden
Copy link
Contributor

@nfuden nfuden commented Jun 17, 2024

Description

XDS pollution occurs with flakey ordering of xds resources as detected in enterprise nack detector for fallback cluster in the case of invalid routes.

This makes enterprise tests fail and can potentially make cluster load assignment appear out of sync until a new update occurs or a pod rolls.

Given that actual impact on production systems is low and the danger of other failing tests not being caught in the interim this is a patch to clean up our test runs.

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

Visit the preview URL for this PR (updated for commit 8de4e7b):

https://gloo-edge--pr9634-fix-kube-tests-omit-u37tex6y.web.app

(expires Tue, 25 Jun 2024 21:13:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@nfuden nfuden marked this pull request as draft June 17, 2024 22:04
@nfuden nfuden marked this pull request as ready for review June 18, 2024 12:42
@nfuden
Copy link
Contributor Author

nfuden commented Jun 18, 2024

https://github.com/solo-io/gloo/actions/runs/9566653960?pr=9637 shows the new reporting structure where multiple failures are shown

@jenshu jenshu merged commit 31de4fc into main Jun 19, 2024
20 checks passed
@jenshu jenshu deleted the fix/kube-tests-omit-flakey-xds branch June 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants