Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config files located in home directory on Windows. #163

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

hsluoyz
Copy link
Contributor

@hsluoyz hsluoyz commented Jun 22, 2018

The current code fails to get the home directory on Windows. This PR will get home like C:\Users\xxx on Windows.

This fixed: #158

@ilackarms
Copy link
Member

lgtm

@ilackarms ilackarms merged commit d0f6787 into solo-io:master Jun 25, 2018
@kspalaiologos
Copy link

Would you mind releasing binaries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error starting daemon on Windows.
3 participants