Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message box when clicking "More" in AmiiDB results list #245

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

Schokobecher
Copy link
Contributor

This should close #241

  • Added _L_APP_AMIIDB_MORE_MESSAGE in English and German
  • Added message box handling to amiidb_scene_amiibo_search.c
  • Rebuilt language files

Pressing [More...] leads the user to this screen:
673E5496-B3E3-410C-8FE0-7A301D90D5F2

Confirming leads them back to the search result scene.

To-do:
Translate _L_APP_AMIIDB_MORE_MESSAGE in other languages

@MayanKoyote
Copy link
Contributor

MayanKoyote commented Apr 9, 2024

Since this is both information and advice/instructions for action, why not use the [_L_KNOW] button here (which means “Got it”)?
Because there is essentially nothing to confirm in such a situation.

@Schokobecher
Copy link
Contributor Author

Schokobecher commented Apr 9, 2024

Both strings convey the same meaning. You could argue that we can remove both, and just use OK in any instance where they are currently in use, and nobody would notice or care.

The user confirms (Confirm)/acknowledges(Got it) that he has seen

  • That there is either an issue
  • or something has to be done by the user to progress

@MayanKoyote
Copy link
Contributor

In situations where the user can say 'I confirm', he can also say 'I do not confirm' in case he doesn't like it. In other words it's 'I cancel' or simply 'Cancel'.
In the case where the user does not have the power of choice (as in this search case), the user can only take note of it by saying 'Got it'. Just like in case of missing key-file.

fw/data/i18n.csv Outdated Show resolved Hide resolved
@Schokobecher
Copy link
Contributor Author

In which case the User can always say Ok and Cancel, just like in most programs. So the right thing would be to ditch both strings entirely and use only Ok across the board.

image

image

@solosky
Copy link
Owner

solosky commented Apr 9, 2024

I vote for "OK"

@Schokobecher
Copy link
Contributor Author

I changed it to _L_KNOW for know, since changing unrelated files doesn't really fit this PR's purpose.

139F939D-2362-42F2-814C-7F1BAFC49F38_1_102_o

@solosky solosky merged commit 67654ab into solosky:develop Apr 9, 2024
@solosky
Copy link
Owner

solosky commented Apr 9, 2024

Thanks

MayanKoyote added a commit to MayanKoyote/pixl.js that referenced this pull request Apr 9, 2024
solosky added a commit that referenced this pull request Apr 10, 2024
Russian localization update related to PR #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants