接続中のプレイヤーとかmobとかNPCとかを管理する仕組みを実装（いまはプレイヤーだけ対応） #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
手元で動いたのでマージするで |
|
いろいろ構造変えたからコメントつけようとおもったけどマージされちゃったか |
|
マージしたらコメント残せないんだっけ |
|
いや、これで大丈夫かな的な相談を入れようかと思ってた |
|
言ってみなさい |
|
これで大丈夫かな |
|
|
||
| /** @override */ | ||
| Entity.prototype.toJSON = function() { | ||
| var json = {}; |
|
Socket の情報からuserid を決定するようなものはない？無いなら実装する． |
| Entities.prototype.removePlayerById = function(userId) { | ||
| this.players_ = _.reject(this.players_, function(player) { | ||
| return player.id === userId; | ||
| }); |
There was a problem hiding this comment.
ここらへんってもしかして delete でも良いとか？
delete this.players_[userId];
There was a problem hiding this comment.
deleteでよかった。そしてこのメソッド使ってなかった。
https://github.com/soltycabbage/BeamQuest/pull/15/files#diff-b3221516324f5cc0ea5614443036d4ddR57 みたいに書けばsocketとuserIDの対応付けが取れるけど |
|
なるほど（イベント・ドリブンの思考になれてなかった） |
|
修正してmasterにぶっこんだ |
|
じつはrejectつかってるところもう一箇所ある |
|
そこはdeleteじゃだめ |
|
ほう（流し見だったからよくみてない） |
|
そうでもなかった |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.