Integrate SOLVCON and gmsh build #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm weird. Something wrong with my re-based history to have a clean history. Let me re-upload the result again. |
This commit is the first step to support the SOLVCON application to use gmsh as recent as possible, so in the end we will have a chance to migrate SOLVCON to newer python instead of the current python 3.6, which will be EOL in a few months. solvcon/solvcon#236
tai271828
force-pushed
the
pr-solvcon-gmsh-devenv-build
branch
from
ab6d9bf
to
b5565b7
Compare
tai271828
commented
May 8, 2021
|
Re-submiied. This pull request is ready to review. |
yungyuc
requested changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have introduced gmsh as one of our build component in this commit #19 . This pull request is a follow-up task to integrate the usage of gmsh build component of
devenvand SOLVCON.How to Test This Pull Request
source scripts/initdevnev add solvcon-01devenv use solvcon-01bin/build-application-solvcon-devenv.shExpected Result
SOLVCON could pass its unittest with the environment built by devenv.