Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manifest] Add() not allowing my local filepath #101

Closed
dandanxu opened this issue Jul 29, 2016 · 1 comment
Closed

[Manifest] Add() not allowing my local filepath #101

dandanxu opened this issue Jul 29, 2016 · 1 comment

Comments

@dandanxu
Copy link
Member 

manifest = solvebio.Manifest()
manifest.add(path='~/Desktop/data.json.gz')

is causing

ValueError: Paths in manifest must be valid URL (starting with http:// or https://) or a valid local filename, directory, or glob (such as: *.vcf)

Maybe something in /resource/manifest.py is not recognizing tildes?
@jsh2134
Copy link
Contributor

jsh2134 commented Jul 29, 2016

i had this same issue, need to use full path

@davecap davecap closed this as completed in 6b3533d Aug 3, 2016
davecap added a commit that referenced this issue Aug 3, 2016
@davecap
Merge pull request #104 from solvebio/fix-manifest-paths
2198660 
expanduser prior to checking ispath or isdir in manifest (fixes #101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsh2134 @dandanxu