Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default restore storage class issue and change to Standard-IA instead of Standard #408

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix default restore storage class issue and change to Standard-IA instead of Standard #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions solvebio/resource/object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,13 +592,9 @@ def restore(self, storage_class=None, follow=False, **kwargs):
if not self.is_dataset:
raise SolveError("Only datasets can be restored.")

# The default storage class for most accounts is Standard
# This is simplest for now. We could also:
# - choose the Vault.default_storage_class if set
# - the Account.default_storage_class if set (and exposed?)
# - get the most recent Dataset snapshot task and pull config from there
# By default, datasets will be restored to Standard-IA
if not storage_class:
self.storage_class = "Standard"
storage_class = "Standard-IA"

# Updating storage class is only available at the objects endpoint
self.storage_class = storage_class
Expand Down