Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make API a monolithic module #10

Closed
1 task done
agarwal opened this issue Oct 26, 2015 · 3 comments
Closed
1 task done

make API a monolithic module #10

agarwal opened this issue Oct 26, 2015 · 3 comments
Assignees

Comments

@agarwal
Copy link
Member

agarwal commented Oct 26, 2015

In contrast to most of our projects, this one will be easiest to use with all types and functions under a single module. Concretely, we should:

[ ] merge pure library to async-unix. The separation is an unnecessary annoyance for now, but could be reintroduced later if any users needed to avoid the async dependency.

  • Either put all code directly into a single phat.ml/i file, or do include Path and include Filesys. Don't worry about the fact that our build system will forcibly name the module Phat_async_unix.Std. We'll fix that later. For now, client code can do module Phat = Phat_async_unix.Std.
@agarwal
Copy link
Member Author

agarwal commented Oct 27, 2015

I've crossed out the first request here. I already have some need for the Path module in a pure library of another project. Nonetheless, we can still include modules to create a final monolithic API.

@pveber
Copy link
Contributor

pveber commented Oct 27, 2015

well, good thing I had not started it yet ;o)

2015-10-27 21:26 GMT+01:00 Ashish Agarwal notifications@github.com:

I've crossed out the first request here. I already have some need for the
Path module in a pure library of another project. Nonetheless, we can
still include modules to create a final monolithic API.


Reply to this email directly or view it on GitHub
#10 (comment).

@agarwal agarwal self-assigned this Oct 28, 2015
@agarwal
Copy link
Member Author

agarwal commented Nov 2, 2015

Done in 4719dd4.

@agarwal agarwal closed this as completed Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants