Automatically colour and (optionally) hide passed exams #1
Conversation
|
Thanks for being the first contributor to NPU 😃 |
| @@ -1205,6 +1438,10 @@ var npu = { | |||
| dec = tmp_arr.join(""); | |||
| return dec; | |||
| }, | |||
|
|
|||
| isPassingGrade: function(gradeStr) { | |||
| return gradeStr != "Elégtelen"; | |||
There was a problem hiding this comment.
If we are doing this, then let's also add Nem felelt meg and Fail for the 3-grade evaluation and the English UI, just to be comprehensive.
There was a problem hiding this comment.
Oh, and I almost forgot Nem jelent meg and Did not attend.
|
Added a few comments, otherwise it looks good 👍 |
|
Neptun build |
|
Well, actually, it was easier to fix than I thought. 💨 |
| } else if (npu.getLanguage() == "en") { | ||
| return gradeStr != "Fail" && gradeStr != "Did not attend"; | ||
| } else if (npu.getLanguage() == "de") { | ||
| // ??? |
There was a problem hiding this comment.
Apparently, the German version uses Hungarian grade names, so there is no need for the de branch.
|
Looks like there's a small oversight still in the script which will need further attention.
Obviously it happens because the "Hide subjects" function works by taking the subject names for the completed rows and removing them from the listbox. I'm thinking about locally caching the list of completed subjects once they appear in the user's browser. This has the drawback of bogusly ignoring a subject making it unfilterable in the future... The other approach would be completely overriding Neptun's features and making the filter happen locally. So from Neptun all the exams are always queried, and from it, NPU filters using the listbox's current selection. This latter option - if implemented properly - has the upside of making it possible to hide subjects (from the listbox) which do not have any exam available (for example, practice courses). |
| } | ||
| }, 100); | ||
| }, 500); |
There was a problem hiding this comment.
Neptun server response times on BME is a lot higher than on others like ELTE or Unideb. I'm talking about ~800ms versus 40-80 ones.
In the long run, the script might as well just be made sentient that it listens to the reponse times and saves it in its database and uses timeout intervals accordingly.
|
Is there anything else that should be implemented or is there a chance we go live with this? 😄 |
|
Let me test your recent changes one last time. If everything works fine, I'll release it 👍 |
|
Unfortunately I've discovered a few consistency issues caused by the subject filtering override (+ extensive flickering when switching between terms), and wasn't able to find an easy fix for them. This means that the subject select box filtering will have to be removed for now 😢 I've prepared another PR (#3) which does that, and also removes the subrow expansion override, an additional simplification. May I ask you to test in your Neptun whether the rest of the features work as expected? I feel bad about removing so much of your new code, as you clearly put a lot of effort in it. However, I would feel just as bad for not putting the highly useful exam list filtering and coloring features into the hands of our users as soon as possible. We can re-add the select box filtering feature once we find a solution for the inconsistencies. |
…tbox This approach should fix the flickering and abusive behaviour mentioned in solymosi#1 and solymosi#5
I've added a few presentational features to NPU in regards to exams (what's better to do than learning right now 🍺 ).
Subjects from which you have a passing grade will now have their exams coloured green to easily distinguish them as you no longer NEED to do an exam. Subjects you have only received failing grades will have a red background.
To make exam registration an easier process, a new user option is also introduced: it is now possible to hide exams from subjects you have passed (these are the now green background ones). Selecting this option will also remove the subject from the "subject:" filter drop-down.
Subject grades are selected from the latest registered mark in accordance with usual University Rules. The same colouring scheme is applied to "my signed exams" page.
Tested to work with ELTE, BME and BCE Neptuns. I've tried my best to keep the coding style to yours. 😃