Config Split #69
Merged
Config Split #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly, the configuration imports in various modules have been refactored for better organization. Configurations have now been split into 'smib.slack.config' and 'smib.webserver.config' files, ensuring that the relevant configurations are loaded for each specific module. Docker build arguments have also been added to exclude unnecessary directories during the build process, making the build more efficient. There is a core smib.common.config which holds configuration necessary to both parts of the app. Docker compose file/build file have had an argument added to remove the other containers source, this is to stop an dependancy injection issue. Also makes the respective images a tad smaller
|
blocked by #68 I should've based this branch off of that one |
|
@sam57719 Merge branch 68 into this one and keep it open. We can merge 68 into develop and then 69 on top later, or just merge 69 in and discard 68 as we need. |
The Docker configuration files, docker-compose.yml and smib-fast.Dockerfile, have been modified to remove the 'exclude_dir' argument. This argument was previously used to exclude directories from the Docker build process, however, this exclusion was found unnecessary. Now, the Docker build workflow is simpler and does not exclude any directories. This is now done in the load_injection_container calls to properly sort the injection issues
|
@sjefferson99 this now should be able to go in separatley to the docker branches #68 - found better way of sorting the injectable issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split config