Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to output logic #849

Merged
merged 3 commits into from
Dec 26, 2021
Merged

Improvements to output logic #849

merged 3 commits into from
Dec 26, 2021

Conversation

somewhatabstract
Copy link
Owner

Summary:

  • Fixes a bug that would lead to some files failing to report their errors if other files had unfixable problems
  • Fixes a bug that would lead to some auto-fixes not being applied if other files had unfixable problems
  • Outputs list of files with unfixable errors
  • Changes labels of log output to fixed width and changes formatting to try and make things easier to read
  • Changes all unfixable errors to be output as actual errors
  • Adds a little more verbose logging

Issue: XXX-XXXX

Test plan:

yarn test

Also ran the tool to check.

Fixes a bug in the output logic and tries to make output more readable.
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #849 (0b07f36) into main (1b7b343) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #849   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          682       686    +4     
  Branches       145       148    +3     
=========================================
+ Hits           682       686    +4     
Impacted Files Coverage Δ
src/format.js 100.00% <100.00%> (ø)
src/maybe-report-error.js 100.00% <100.00%> (ø)
src/output-sink.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8999b...0b07f36. Read the comment docs.

@somewhatabstract somewhatabstract merged commit 75ea08a into main Dec 26, 2021
@somewhatabstract somewhatabstract deleted the outputfixes branch December 26, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant