SCANPY-102 New bootstrapping: Execute the Scan #148
Conversation
thomas-serre-sonarsource
changed the base branch from
master
to
branch-SCANPY-98
There was a problem hiding this comment.
The general logic looks sound to me. The only issue regarding the logic is that the version check isn't done as the first step, but only after the JRE and scanner engine provisioning.
Apart from that, I'm not convinced that we should override __str__ for the CacheFile and JREProvisionedPath (see comment for more detail).
I've also left some other smaller nit picks.
| cmd = self.__build_command(jre_path) | ||
| print(cmd) | ||
| popen = Popen(cmd, stdout=PIPE, stderr=PIPE, stdin=PIPE) | ||
| outs, _ = popen.communicate(configuration.to_json().encode()) |
There was a problem hiding this comment.
The way this currently processes the log files means that there is no output from the scanner engine at all.
We probably should do this similarly to how it was done in the current master (see here)
However, I think it would be fine to do this as a separate ticket
There was a problem hiding this comment.
|
SCANPY-102