Allow auditing of entities with many-many relations #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes made in c619a4e have made it impossible to load the history of entities that have a many to many relationship with another entity. I think the old approach of just providing an empty collection and the notice in the docs is preferable to not being able to audit the entity at all. Hence I reverted the change that throws an exception if a many to many relationship is found
tommygnr
force-pushed
the
allow-m2m-audit
branch
from
98b6647
to
ee78e4e
Compare
|
I have added the test |
DavidBadura
added a commit
that referenced
this pull request
Dec 10, 2014
Allow auditing of entities with many-many relations
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in c619a4e have made
it impossible to load the history of entities that have a many to many
relationship with another entity. I think the old approach of just
providing an empty collection and the notice in the docs is preferable
to not being able to audit the entity at all. Hence I reverted the
change that throws an exception if a many to many relationship is found