Set twig globals after first admin instanciation

[AntoineRoue]

Fixes #8120

Changelog

### Fixed
- Needing to submit form twice when using CRUDController::render()

[AntoineRoue]

I should have converted it to draft but did not find the button. It's done now.

[VincentLanglet]

Thanks !

[core23]

Sorry for the late feedback. This solution does only work if your Controller extends the CRUDController.

If you want to create small (batch) action controller, there is no need to extend that controller and this solution does not work.

[AntoineRoue]

If you don't extend CRUDController, then do you really need 'admin' and 'base_template' variables in twig ?

Before these globals were set, if extended CRUDController then we had to use CRUDController::renderWithExtraParams to render the template. Without extending CRUDController, if we wanted these variable in twig, we had to add them ourself when rendering the template. In the end, it would work like before no ?

[Warxcell]

Unfortunately this breaks when inside long-running process like roadrunner. It throws exception that admin already exists as global, because it was set by previous admin.

[VincentLanglet]

Unfortunately this breaks when inside long-running process like roadrunner. It throws exception that admin already exists as global, because it was set by previous admin.

Hi, can you try the 4.29.1 version ?

[Warxcell]

Unfortunately this breaks when inside long-running process like roadrunner. It throws exception that admin already exists as global, because it was set by previous admin.

Hi, can you try the 4.29.1 version ?

I saw the fix, but isn't that just hiding the error? Seems like the global twig variable admin will stay forever as initially set, and all furhter reads will read the first admin instance.

[VincentLanglet]

I saw the fix, but isn't that just hiding the error? Seems like the global twig variable admin will stay forever as initially set, and all furhter reads will read the first admin instance.

I'm not sure about this since the code allows to update globals:

/**
     * Registers a Global.
     *
     * New globals can be added before compiling or rendering a template;
     * but after, you can only update existing globals.
     *
     * @param mixed $value The global value
     */
    public function addGlobal(string $name, $value)
    {
        if ($this->extensionSet->isInitialized() && !\array_key_exists($name, $this->getGlobals())) {
            throw new \LogicException(sprintf('Unable to add global "%s" as the runtime or the extensions have already been initialized.', $name));
        }

        if (null !== $this->resolvedGlobals) {
            $this->resolvedGlobals[$name] = $value;
        } else {
            $this->globals[$name] = $value;
        }
    }

[Warxcell]

I saw the fix, but isn't that just hiding the error? Seems like the global twig variable admin will stay forever as initially set, and all furhter reads will read the first admin instance.

I'm not sure about this since the code allows to update globals:

/**
     * Registers a Global.
     *
     * New globals can be added before compiling or rendering a template;
     * but after, you can only update existing globals.
     *
     * @param mixed $value The global value
     */
    public function addGlobal(string $name, $value)
    {
        if ($this->extensionSet->isInitialized() && !\array_key_exists($name, $this->getGlobals())) {
            throw new \LogicException(sprintf('Unable to add global "%s" as the runtime or the extensions have already been initialized.', $name));
        }

        if (null !== $this->resolvedGlobals) {
            $this->resolvedGlobals[$name] = $value;
        } else {
            $this->globals[$name] = $value;
        }
    }

Yes, but only if no exception is thrown? In our case - exception IS thrown.

[VincentLanglet]

Yes, but only if no exception is thrown? In our case - exception IS thrown.

According to if ($this->extensionSet->isInitialized() && !\array_key_exists($name, $this->getGlobals())) {

Exception is thrown only if the global doesn't exists and the extension is initialized.
So no exception is thrown in your example.

Let's end this theoretically discussion here and wait for a well-reported bug instead if it exists.