This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
Use choice_translation_domain in BooleanType #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
force-pushed
the
remove/flash-manager
branch
2 times, most recently
from
bbd0c33
to
f15746d
Compare
OskarStark
suggested changes
Oct 3, 2016
| @@ -173,6 +174,10 @@ public function testOptions() | |||
| unset($expectedOptions['choices_as_values']); | |||
| } | |||
|
|
|||
| if (!method_exists('Symfony\Component\Form\AbstractType', 'configureOptions')) { | |||
| @@ -81,6 +81,8 @@ public function configureOptions(OptionsResolver $resolver) | |||
| if (method_exists('Symfony\Component\Form\AbstractType', 'configureOptions')) { | |||
| $choices = array_flip($choices); | |||
|
|
|||
| $defaultOptions['choice_translation_domain'] = 'SonataCoreBundle'; | |||
|
|
|||
| // choice_as_value options is not needed in SF 3.0+ | |||
| if (method_exists('Symfony\Component\Form\FormTypeInterface', 'setDefaultOptions')) { | |||
core23
force-pushed
the
remove/flash-manager
branch
from
f15746d
to
5d8fe79
Compare
OskarStark
approved these changes
Oct 4, 2016
|
Thank you @core23 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because this is a patch.
Changelog
Subject
When setting the
translation_domainoption in an custom form, only the label should get affected. Theyesandnolabels should stay.