Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

DevKit updates for 2.x branch #540

Merged
merged 20 commits into from
Jan 15, 2019
Merged

DevKit updates for 2.x branch #540

merged 20 commits into from
Jan 15, 2019

Conversation

SonataCI
Copy link
Collaborator

@SonataCI SonataCI commented Nov 29, 2018

Subject

I am targeting this branch, because this is BC.

Changelog

### Removed
- support for php 5 and php 7.0

core23
core23 previously approved these changes Dec 6, 2018
greg0ire and others added 5 commits January 14, 2019 08:27
Some deprecated service cause deprecations from
tests/Resources/app/var/cache, and this is not considered as a vendor.
@greg0ire greg0ire merged commit 03b0395 into 2.x Jan 15, 2019
@greg0ire greg0ire deleted the 2.x-dev-kit branch January 15, 2019 23:45
@greg0ire
Copy link
Contributor

Finally! @core23 I had to switch to weak instead of weak_vendors to have this pass, because weak_vendors wrongly thinks that deprecations coming from test/app/cache are non-vendor deprecations, when in fact they are deprecations about core bundle services. dev-kit will re-add the mode, so it would be great to use new service, but I don't know which should be used (the deprecation message does not say in favor of what each service is deprecated). Can you please help with this?

@greg0ire greg0ire added the minor label Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants