Allow "friendsofsymfony/rest-bundle:^3.0" #1767

wbloszyk · 2020-07-16T15:50:45Z

Subject

Allow "friendsofsymfony/rest-bundle:^3.0".

I am targeting this branch, because these changes respect BC.

Changelog

### Added
- Added support for "friendsofsymfony/rest-bundle:^3.0"
### Change
- support for deprecated "rest" routing type in favor for xml

phansys · 2020-07-16T16:31:41Z

The commit dadd6ab seems unrelated given the PR title and description.

src/Controller/Api/GalleryController.php

wbloszyk · 2020-07-17T10:46:05Z

I got critical error in tests:

[critical] Uncaught PHP Exception Symfony\Component\Config\Exception\LoaderLoadException: "[ERROR 1866] Element '{http://symfony.com/schema/routing}import', attribute 'name-prefix': The attribute 'name-prefix' is not allowed. (in /home/zbiru/PhpstormProjects/sonata-project/SonataMediaBundle/ - line 3, column 0)
[ERROR 1866] Element '{http://symfony.com/schema/routing}import', attribute 'name-prefix': The attribute 'name-prefix' is not allowed. (in /home/zbiru/PhpstormProjects/sonata-project/SonataMediaBundle/ - line 4, column 0) in /home/zbiru/PhpstormProjects/sonata-project/SonataMediaBundle/src/Resources/config/routing/api.xml (which is being imported from "/home/zbiru/PhpstormProjects/sonata-project/SonataMediaBundle/tests/App/routes.yml"). Make sure there is a loader supporting the "rest" type." at /home/zbiru/PhpstormProjects/sonata-project/SonataMediaBundle/vendor/symfony/config/Loader/FileLoader.php line 180

https://travis-ci.org/github/sonata-project/SonataMediaBundle/jobs/708806345#L815

Can we change name-prefix to prefix? WDYT? @phansys

src/Resources/config/routing/api.xml

wbloszyk · 2020-07-22T16:41:38Z

I check Route Matching Logs in Symfony Profiler and saw this (the same for this media api):

`#`	Route name	Path	Log
124	sonata_api_user_user_sonata_user_api_user_getusers	/api/user/users	Path does not match
125	sonata_api_user_user_sonata_user_api_user_getuser	/api/user/user/(id}	Path does not match
126	sonata_api_user_user_sonata_user_api_user_postuser	/api/user/user	Path does not match

but should be:

`#`	Route name	Path	Log
124	sonata_api_user_user_get_users	/api/user/users	Path does not match
125	sonata_api_user_user_get_user	/api/user/user/(id}	Path does not match
126	sonata_api_user_user_post_user	/api/user/user	Path does not match

Mybe we should add name to @Router()? Like:

* @Rest\Get("/galleries", name="get_galleries")

This will generate router name: {name-prefix}{router name} = sonata_api_media_gallery_+get_galleries. WDYT? @phansys

phansys · 2020-07-22T17:13:13Z

This will generate router name: {name-prefix}{router name} = sonata_api_media_gallery_+get_galleries. WDYT? @phansys

I agree that if we must keep the previous names, we should take that responsibility.
In that case, the same change should be applied at SonataUserBundle.

wbloszyk · 2020-07-22T17:52:43Z

@phansys Can you fix it for UserBundle? This can be helpful: sonata-project/dev-kit#778 (comment)

phansys · 2020-07-22T23:01:42Z

@phansys Can you fix it for UserBundle? This can be helpful: sonata-project/dev-kit#778 (comment)

Sure. I'll try to provide this fix tomorrow 👍

wbloszyk · 2020-07-24T11:34:47Z

Probably last thing what we should fix is format. I cant generate xml but evan for non fixed bundles. Mybe it is my config but
.{_format} for new routing is missing.

phansys · 2020-07-24T12:19:44Z

Probably last thing what we should fix is format. I cant generate xml but evan for non fixed bundles. Mybe it is my config but
.{_format} for new routing is missing.

I can confirm this happens, since when I bumped this requirements in one of my private projects some time ago I had to add the suffix explicitly. I'll try to provide a fix for SonataUserBundle in order to check.

wbloszyk · 2020-07-24T13:50:41Z

After change _format I still got ***.json?_format=xml. In /api/doc format must be change in right top corner. What is little confusing.

127.0.0.1:8000/api/notification/messages.xml

<result>
<page>1</page>
<per_page>10</per_page>
<last_page>0</last_page>
<total>0</total>
<entries/>
</result>

Anyway I can get result if no object is existing. Probalbly it is some problem with fos_rest.decoder.xml or serializer(but json works).

WDYT? @phansys

phansys · 2020-07-24T16:58:24Z

WDYT? @phansys

I'm not using XML, so I must check first in order to share any concern about this.

jordisala1991 · 2020-07-26T15:01:20Z

Is this one ready to review?

wbloszyk · 2020-07-26T15:08:46Z

@jordisala1991 I working on test now. I will write when finish it.

tests/App/config.yml

wbloszyk · 2020-07-26T19:06:17Z

@jordisala1991 @greg0ire It is RTM, but i can find why --prefer-lowest don't work.

tests/App/config.yml

src/Resources/config/routing/api.xml

src/Controller/Api/MediaController.php

VincentLanglet

This could be great to make a merge 3.x into master after this. We're starting to have a lot of conflict to merge ^^

jordisala1991 · 2020-07-31T06:05:45Z

Plus, this one is a hard merge because there are entity changes. I can deal with it after the merge

wbloszyk · 2020-07-31T08:04:41Z

Finally it is RTM.

If it is hard to merge 3,x to master we can split it to 2 PRs. Can you merge 3 PRs? and I will merge PRs with my work then. @jordisala1991

phansys · 2020-07-31T16:15:32Z

src/Resources/config/routing/api/gallery.xml

+    <route id="get_gallery_medias" path="/galleries/{id}/medias.{_format}" methods="GET" controller="Sonata\MediaBundle\Controller\Api\GalleryController::getGalleryMediasAction" format="json">
+        <requirement key="_format">json|xml|html</requirement>
+    </route>
+    <route id="get_gallery_galleryhasmedias" path="/galleries/{id}/galleryhasmedias.{_format}" methods="GET" controller="Sonata\MediaBundle\Controller\Api\GalleryController::getGalleryGalleryhasmediasAction" format="json">


I'd like to have this list sorted by id, but it's not really a blocker.

I check it. Better keep it in this way becouse order in config is equal to order in nelmio doc. Its look much better when we keep this order.

VincentLanglet · 2020-07-31T23:28:55Z

@jordisala1991 @wbloszyk Have a good merge ! 😁

wbloszyk · 2020-08-01T08:29:42Z

@VincentLanglet @jordisala1991 Many conflits but easy to resolve: #1775

phansys reviewed Jul 16, 2020

View reviewed changes

src/Controller/Api/GalleryController.php Outdated Show resolved Hide resolved

phansys reviewed Jul 17, 2020

View reviewed changes

src/Resources/config/routing/api.xml Outdated Show resolved Hide resolved

wbloszyk force-pushed the support_rest_3 branch from 1564624 to 5ca80c9 Compare July 22, 2020 14:41

wbloszyk closed this Jul 22, 2020

wbloszyk reopened this Jul 22, 2020

wbloszyk mentioned this pull request Jul 24, 2020

RestFul API - fix and upgrade description sonata-project/dev-kit#778

Closed

43 tasks

wbloszyk force-pushed the support_rest_3 branch from 5ca80c9 to 00329e3 Compare July 24, 2020 10:19

phansys mentioned this pull request Jul 24, 2020

Fix passing "format" parameter to API routes sonata-project/SonataUserBundle#1195

Merged

wbloszyk force-pushed the support_rest_3 branch from 00329e3 to 04867fe Compare July 26, 2020 15:26

FlintCIBot reviewed Jul 26, 2020

View reviewed changes

tests/App/config.yml Outdated Show resolved Hide resolved

FlintCIBot reviewed Jul 26, 2020

View reviewed changes

tests/App/config.yml Outdated Show resolved Hide resolved

wbloszyk force-pushed the support_rest_3 branch 4 times, most recently from 19241e8 to 594429e Compare July 26, 2020 16:04

wbloszyk marked this pull request as ready for review July 26, 2020 18:42

wbloszyk requested a review from phansys July 26, 2020 19:00

phansys reviewed Jul 28, 2020

View reviewed changes

tests/App/config.yml Outdated Show resolved Hide resolved

phansys reviewed Jul 28, 2020

View reviewed changes

src/Resources/config/routing/api.xml Outdated Show resolved Hide resolved

wbloszyk force-pushed the support_rest_3 branch 3 times, most recently from d81b441 to eb9d51e Compare July 30, 2020 18:18

wbloszyk requested review from phansys and jordisala1991 July 30, 2020 18:27

phansys reviewed Jul 30, 2020

View reviewed changes

src/Controller/Api/MediaController.php Outdated Show resolved Hide resolved

wbloszyk force-pushed the support_rest_3 branch from cca49b0 to 77e54cb Compare July 30, 2020 21:41

wbloszyk requested a review from phansys July 30, 2020 21:42

phansys previously approved these changes Jul 30, 2020

View reviewed changes

VincentLanglet previously approved these changes Jul 30, 2020

View reviewed changes

Allow "friendsofsymfony/rest-bundle:^3.0"

3b05773

wbloszyk dismissed stale reviews from VincentLanglet and phansys via 3b05773 July 31, 2020 07:50

wbloszyk force-pushed the support_rest_3 branch from 77e54cb to 3b05773 Compare July 31, 2020 07:50

wbloszyk requested review from phansys and VincentLanglet July 31, 2020 07:53

wbloszyk mentioned this pull request Jul 31, 2020

Use XML for ReST API routing sonata-project/SonataNotificationBundle#457

Merged

jordisala1991 approved these changes Jul 31, 2020

View reviewed changes

phansys reviewed Jul 31, 2020

View reviewed changes

phansys approved these changes Jul 31, 2020

View reviewed changes

VincentLanglet approved these changes Jul 31, 2020

View reviewed changes

VincentLanglet merged commit 332ad2e into sonata-project:3.x Jul 31, 2020

wbloszyk deleted the support_rest_3 branch August 1, 2020 07:41

wbloszyk mentioned this pull request Aug 3, 2020

Revert added type hints #1779

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow "friendsofsymfony/rest-bundle:^3.0" #1767

Allow "friendsofsymfony/rest-bundle:^3.0" #1767

wbloszyk commented Jul 16, 2020 •

edited

Loading

phansys commented Jul 16, 2020

wbloszyk commented Jul 17, 2020 •

edited

Loading

wbloszyk commented Jul 22, 2020

phansys commented Jul 22, 2020

wbloszyk commented Jul 22, 2020

phansys commented Jul 22, 2020

wbloszyk commented Jul 24, 2020

phansys commented Jul 24, 2020

wbloszyk commented Jul 24, 2020 •

edited

Loading

phansys commented Jul 24, 2020

jordisala1991 commented Jul 26, 2020

wbloszyk commented Jul 26, 2020

wbloszyk commented Jul 26, 2020

VincentLanglet left a comment

jordisala1991 commented Jul 31, 2020

wbloszyk commented Jul 31, 2020

phansys Jul 31, 2020

wbloszyk Jul 31, 2020

VincentLanglet commented Jul 31, 2020

wbloszyk commented Aug 1, 2020

Allow "friendsofsymfony/rest-bundle:^3.0" #1767

Allow "friendsofsymfony/rest-bundle:^3.0" #1767

Conversation

wbloszyk commented Jul 16, 2020 • edited Loading

Subject

Changelog

phansys commented Jul 16, 2020

wbloszyk commented Jul 17, 2020 • edited Loading

wbloszyk commented Jul 22, 2020

phansys commented Jul 22, 2020

wbloszyk commented Jul 22, 2020

phansys commented Jul 22, 2020

wbloszyk commented Jul 24, 2020

phansys commented Jul 24, 2020

wbloszyk commented Jul 24, 2020 • edited Loading

phansys commented Jul 24, 2020

jordisala1991 commented Jul 26, 2020

wbloszyk commented Jul 26, 2020

wbloszyk commented Jul 26, 2020

VincentLanglet left a comment

Choose a reason for hiding this comment

jordisala1991 commented Jul 31, 2020

wbloszyk commented Jul 31, 2020

phansys Jul 31, 2020

Choose a reason for hiding this comment

wbloszyk Jul 31, 2020

Choose a reason for hiding this comment

VincentLanglet commented Jul 31, 2020

wbloszyk commented Aug 1, 2020

wbloszyk commented Jul 16, 2020 •

edited

Loading

wbloszyk commented Jul 17, 2020 •

edited

Loading

wbloszyk commented Jul 24, 2020 •

edited

Loading