Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixlr not able to handle nullable extension #2076

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is a bugfix.

Backporting directly from master branch.

Closes #1670 .

Changelog

### Fixed
- Fixed adding new Media with Pixlr enabled.

Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be updated as well?

/**
* @return string
*/
public function getExtension();

@jordisala1991
Copy link
Member Author

Shouldn't this be updated as well?

/**
* @return string
*/
public function getExtension();

@phansys is already modifying the phpdoc at other Pr.

@jordisala1991 jordisala1991 merged commit b0b1fac into sonata-project:3.x Aug 16, 2021
@jordisala1991 jordisala1991 deleted the hotfix/pixlr branch August 16, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonata\AdminBundle\Form\Type\ModelListType with media items breaks on adding a new
3 participants