Deprecate index and view controller method #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
feature/deprecate-some-classes
branch
3 times, most recently
from
75f9722
to
bc172a6
Compare
jordisala1991
force-pushed
the
feature/deprecate-some-classes
branch
from
bc172a6
to
e65341f
Compare
VincentLanglet
approved these changes
Sep 12, 2021
core23
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
We should deprecate those methods because they do not provide any value and they can be easily implement in case someone needs to show a media detail and list of galleries.
Breadcrumb were directly related to those actions. Again , if someone need those actions for the frontend of his app. He might need or not the breadcrumbs.
Changelog