Configurable s3 adapter

[ozahorulia]

Added configuration to set AWS S3 adapter class

I am targeting this branch, because it adds a configuration feature with full BC.

Closes #2357 .

Changelog

### Added
- Added new configuration parameter `sonata_media.filesystem.s3.async`

[ozahorulia]

On a real project it fails because of this error:

Gaufrette\Adapter\AsyncAwsS3::__construct(): Argument #1 ($service) must be of type AsyncAws\SimpleS3\SimpleS3Client, ContainerEmExVd8\S3Client_76b2022 given,

I have to think how to pass async client instead of the simple one

[VincentLanglet]

On a real project it fails because of this error:

Gaufrette\Adapter\AsyncAwsS3::__construct(): Argument #1 ($service) must be of type AsyncAws\SimpleS3\SimpleS3Client, ContainerEmExVd8\S3Client_76b2022 given,

I have to think how to pass async client instead of the simple one

Is there other adapters ?
If not, you may use a config async: true/false instead of the class.
And then if config = true, you define the async, else you define the original one.
This allows to have different constructors.

[ozahorulia]

Is there other adapters ? If not, you may use a config async: true/false instead of the class. And then if config = true, you define the async, else you define the original one. This allows to have different constructors.

Yes, this is exactly what I'm going to do. Since there're indeed no other adapters, async options looks much more useful. I'm working on it.

[VincentLanglet]

Can you solve the deprecation instead ? :)

[ozahorulia]

I'd leave it as it is right now, because phpunit doesn't provide any replacement for the withConsecutive method, and I'm way out of the context of this test case to thoroughly re-write the test. Any proposed workarounds, like using callbacks with match (switch if we still support 7.4) look very hideous to me.

[VincentLanglet]

One last question, why this was removed ?

[ozahorulia]

It's already in the "require" section with the same versions. Does it makes sense to have a duplicate entry in require-dev? I can roll it back if it was there for a reason :)

[VincentLanglet]

didn't see the require section. You were right to remove it then. thnaks

[ozahorulia]

@VincentLanglet Thank you! May I ask you to create a minor release, so I can use it in my projects?

[VincentLanglet]

Done

[ozahorulia]

Thank you!