Re-allow SF DI>4.4.0 & upgrade di test package

[mazsudo]

Subject

I am targeting this branch, because it does not contain BC break i guess.

to understand this:

• symfony/dependency-injection@ddb0228
• SymfonyTest/SymfonyDependencyInjectionTest@3431fc9

Changelog

### Changed
- Re-allow SF DI>4.4.0
- Upgrade matthiasnoback/symfony-dependency-injection-test to ^4.0

[greg0ire]

If you want to use the latest di test package, you will have to upgrade phpunit to version 8 (can be done in .travis.yml. If that works, we will have to do a dev-kit PR.

[greg0ire]

You will have to add :void to all setUp and tearDown methods if you want this to work.

[mazsudo]

not sure but according to the build i guess i need to open a PR on CoreBundle

[mazsudo]

waiting for sonata-project/SonataCoreBundle#729 to be merged :)

[core23]

waiting for sonata-project/SonataCoreBundle#729 to be merged :)

The CoreBundle is deprecated, please try to port the breaking code to this bundle, otherwise we must do this, when we drop the CoreBundle (e.g. on the master branch)

[mazsudo]

@core23 don't think there is any breaking code to port here. Build is just failing because of CoreBundle or am I miss understanding?

[greg0ire]

@core23 is saying you should just copy the XliffValidatorTestCase to the page bundle if I understand correctly.

[mazsudo]

almost understood. However, even with migrating all tests from CoreBundle to PageBundle (because some others will make the build fail), without merging anything in CoreBundle it will still fail. Or do we need to merge the removal of all test inside CoreBundle first? Not sure of what i have to do here sorry 😬

[greg0ire]

XliffTest should no longer extend the class from the core bundle I think. You can copy all necesseary method from XliffValidatorTestCase to it. That will remove the dependency to the core bundle for tests.

because some others will make the build fail

Some other tests? Which ones?

[mazsudo]

sorry i miss understood the core bundle relationship in the test 😬 hope i did what was expected ;)

[greg0ire]

You did terrific 👍 let's merge

[greg0ire]

I created a PR on dev-kit to make sure we stay with PHPUnit 8: sonata-project/dev-kit#541

Also, I'm going to release a new version of the page bundle