DevKit updates for 3.x branch #667
Conversation
franmomu
force-pushed
the
3.x-dev-kit
branch
2 times, most recently
from
20d4ce5
to
c7413a1
Compare
franmomu
force-pushed
the
3.x-dev-kit
branch
2 times, most recently
from
7cb55cc
to
acf621d
Compare
| */ | ||
| #[ORM\Id] | ||
| #[ORM\Column(type: Types::INTEGER)] | ||
| #[ORM\GeneratedValue()] |
There was a problem hiding this comment.
| #[ORM\GeneratedValue()] | |
| #[ORM\GeneratedValue] |
| */ | ||
| #[ORM\Id] | ||
| #[ORM\Column(type: Types::INTEGER)] | ||
| #[ORM\GeneratedValue()] |
There was a problem hiding this comment.
| #[ORM\GeneratedValue()] | |
| #[ORM\GeneratedValue] |
composer.json
Outdated
| @@ -34,12 +34,13 @@ | |||
| "twig/twig": "^2.12 || ^3.0" | |||
| }, | |||
| "require-dev": { | |||
| "doctrine/doctrine-bundle": "^2.4", | |||
| "doctrine/dbal": "^2.13.9", | |||
There was a problem hiding this comment.
| "doctrine/dbal": "^2.13.9", | |
| "doctrine/dbal": "^3.4", |
We are dropping dbal 2 from all repos.
There was a problem hiding this comment.
I was checking that if I do that, because of https://github.com/KnpLabs/DoctrineBehaviors/pull/682/files, some symfony dependencies will be raised to 5.4.
Maybe it's also time to drop Symfony 4.4? since we are also supporting another LTS (5.4)
There was a problem hiding this comment.
previous doctrine behavior versions also support dbal 3 , so it is fine, afaik you wont be dropping sf 4.4 by doing this
There was a problem hiding this comment.
https://github.com/sonata-project/SonataTranslationBundle/actions/runs/4382455582/jobs/7671520120 this is what I meant, we cannot run the job with symfony 4.4 and using the lowest one https://github.com/sonata-project/SonataTranslationBundle/actions/runs/4382455582/jobs/7671642782#step:7:207 it's installing 5.4
There was a problem hiding this comment.
then you might want to allow dbal 2 and 3, for the moment.
Then we can discuss about dropping symfony 4.4. (I would wait to another round of PRs, since this migration to php8.0 is already taking some time).
wdyt @VincentLanglet ?
franmomu
force-pushed
the
3.x-dev-kit
branch
4 times, most recently
from
3d56385
to
ad20412
Compare
Changelog