Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Fix dispatch event to work with contracts #676

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jun 16, 2020

Subject

This PR replace event dispach parameter to work correctly with constracts.

I am targeting this branch, because this change respect BC.

Changelog

### Fixed
- Deprecations for event dispatching

@jordisala1991
Copy link
Member

You should change: use Symfony\Component\EventDispatcher\EventDispatcherInterface; to use the contract.

Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you require the contracts for event dispatcher on composer?

@wbloszyk
Copy link
Member Author

@jordisala1991
Done. I copy it from AdminBundle. For now version ^2.0 will not be use becouse symfony/event-dispatcher require ^1.1. Anyway support for Symfony5 is close so i keep it here too.

@wbloszyk
Copy link
Member Author

@core23 I update test too. Should I do something more?

@core23
Copy link
Member

core23 commented Jun 18, 2020

Please add a changelog entry, after that it's RTM

@wbloszyk
Copy link
Member Author

@core23 Changelog can be like this?

@core23 core23 merged commit fbb053e into sonata-project:3.x Jun 18, 2020
@core23
Copy link
Member

core23 commented Jun 18, 2020

Thanks @wbloszyk

@wbloszyk wbloszyk deleted the fix_event_dispatch branch June 18, 2020 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants