Increase Psalm to level 2

[jordisala1991]

.

[jordisala1991]

Probably some of this should go to 1.x

[jordisala1991]

The last psalm error makes no sense...

ERROR: PossibleRawObjectIteration - src/EventListener/ResizeFormListener.php:178:18 - Possibly undesired iteration over regular object ArrayAccess (see https://psalm.dev/208)
        foreach ($data as $name => $child) {

It looks like a bug to me, I have tried a lot of combinations and even adding an assert after those if does not make psalm happy

[jordisala1991]

Probably some of this should go to 1.x

I answer to myself, yes it could make sense but a lot of errors are raised on 1.x due to deprecated code, I prefer to not invest time there.

[VincentLanglet]

The last psalm error makes no sense...

ERROR: PossibleRawObjectIteration - src/EventListener/ResizeFormListener.php:178:18 - Possibly undesired iteration over regular object ArrayAccess (see https://psalm.dev/208)
        foreach ($data as $name => $child) {

It looks like a bug to me, I have tried a lot of combinations and even adding an assert after those if does not make psalm happy

Changing

if (!\is_array($data) && !$data instanceof \Traversable) {

to
is_iterable ?

Anyway, I didn't succeed to reproduce the error on psalm.dev ; can you ?
We could open an issue on psalm.

[jordisala1991]

I couldnt reproduce it either.

[VincentLanglet]

I couldnt reproduce it either.

I succeed reproducing a similar issue https://psalm.dev/r/c95d52a172
We could try to add psalm-trace, I think it will be ArrayAccess|array<array-key, mixed>.

Seems like the issue is that the variable is not considered as (Traversable&ArrayAccess)|array<array-key, mixed>.

[jordisala1991]

To me it looks like a bug, should we suppress it for now?

[VincentLanglet]

To me it looks like a bug, should we suppress it for now?

Sure, but we should open an issue on psalm and adding the link in the psalm-suppress IMHO.
Do you do it or should I do ?

[jordisala1991]

To me it looks like a bug, should we suppress it for now?

Sure, but we should open an issue on psalm and adding the link in the psalm-suppress IMHO. Do you do it or should I do ?

vimeo/psalm#7928

Here it is.