Remove deleted elements before submit to avoid triggering validation

[jordisala1991]

Subject

I am targeting this branch, because this is a bug fix.

Closes sonata-project/SonataAdminBundle#4348.

Changelog

### Fixed
- Do not trigger validation on deleted rows of CollectionType

[jordisala1991]

I have tried on a project and now the validation is not triggered when the collection item is marked for deletion.

WDYT @VincentLanglet ?

[VincentLanglet]

I have tried on a project and now the validation is not triggered when the collection item is marked for deletion.

WDYT @VincentLanglet ?

The bug was rely annoying, this is a great fix.
Do you think we have a way to add test here or in sonataAdmin ?

I don't have a project to reproduce the bug and use the fix.

I'm ok merging and releasing this

[jordisala1991]

I have tried on a project and now the validation is not triggered when the collection item is marked for deletion.
WDYT @VincentLanglet ?

The bug was rely annoying, this is a great fix. Do you think we have a way to add test here or in sonataAdmin ?

I don't have a project to reproduce the bug and use the fix.

I'm ok merging and releasing this

It is really problematic to test this properly... form type is here, base templates are on the admin-bundle, BUT the form type widget is on the persistence bundles...

So I guess the only way to test this is on the DoctrineORM/MongoDB persistence bundles, I can try it once released.

[jordisala1991]

Let me try one more way to delete those items. Wait a bit for the merge.

[jordisala1991]

No more changes needed, this is the cleaner solution I could found.

I also tried to make it work somehow like this: https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php

Where on preSubmit it only removed from the $form object, and on the submit it removed from the $data object, but it does not work on our use case. It complains about extra fields (data submitted contains more things that the $form is expecting, because we remove from $form first).

There should be more pieces on Symfony code dealing with that, but I think it is not worth investigating more.

Current behavior is buggy since it does not let you remove invalid items, and the fix improves that.

EDIT: I guess the resizer from Symfony is expecting that when you remove an item, the $data will not contain it, it does not rely on a checkbox for removal, but the full removal on the frontend prior submit, that's why it works this way.

[jordisala1991]

I think this is the most correct solution @VincentLanglet . on Pre Submit we should make sure to remove extra data (data marked for removal) and to remove the form fields for that data (avoid adding them back to the form).

Then onSubmit we don't have:

• Data submitted because we previously filter it
• Form associated fields because it was also removed

Validation will work for fields not removed, but will not be triggered for removed fields.

[jordisala1991]

I will try to prepare a test now for the doctrine orm admin bundle.

[jordisala1991]

Something like this: sonata-project/SonataDoctrineORMAdminBundle#1737