Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vulnerability: CVE-2021-3121 in github.com/gogo/protobuf v1.2.1 #69

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

bhamail
Copy link
Contributor

@bhamail bhamail commented Feb 25, 2021

Copy link
Member

@DarthHater DarthHater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it works! What do we even use protobuf for (I doubt we do, probs brought in by something else?)

@bhamail
Copy link
Contributor Author

bhamail commented Feb 25, 2021

If it works it works! What do we even use protobuf for (I doubt we do, probs brought in by something else?)

Yeah, brought in by something else, e.g. viper:

$ go list -m all | grep 'github.com/gogo/protobuf'
github.com/gogo/protobuf v1.2.1 => github.com/gogo/protobuf v1.3.2
(base) MBP-DRollo5:ahab bhamail$ go mod graph | grep 'github.com/gogo/protobuf'
github.com/spf13/viper@v1.4.0 github.com/gogo/protobuf@v1.2.1
github.com/gogo/protobuf@v1.1.1 github.com/kisielk/errcheck@v1.5.0
github.com/gogo/protobuf@v1.1.1 github.com/kisielk/gotool@v1.0.0
github.com/gogo/protobuf@v1.1.1 golang.org/x/tools@v0.0.0-20210106214847-113979e3529a
github.com/prometheus/tsdb@v0.7.1 github.com/gogo/protobuf@v1.1.1
github.com/gogo/protobuf@v1.2.1 golang.org/x/tools@v0.0.0-20210106214847-113979e3529a
github.com/gogo/protobuf@v1.2.1 github.com/kisielk/gotool@v1.0.0
github.com/gogo/protobuf@v1.2.1 github.com/kisielk/errcheck@v1.5.0
github.com/prometheus/common@v0.4.0 github.com/gogo/protobuf@v1.1.1
github.com/spf13/viper@v1.7.1 github.com/gogo/protobuf@v1.2.1

@bhamail bhamail merged commit 7b22323 into main Feb 25, 2021
@bhamail bhamail deleted the update_protobuf branch February 25, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants