Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build failure by updating to go 1.16 #71

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Fix CI build failure by updating to go 1.16 #71

merged 3 commits into from
Mar 22, 2021

Conversation

bhamail
Copy link
Contributor

@bhamail bhamail commented Mar 22, 2021

Overnight CI build started to fail like so:

go mod tidy
github.com/sonatype-nexus-community/ahab/cmd imports
	github.com/spf13/viper imports
	github.com/spf13/afero imports
	io/fs: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)
github.com/sonatype-nexus-community/ahab/cmd imports
	github.com/spf13/viper imports
	github.com/spf13/afero tested by
	github.com/spf13/afero.test imports
	testing/fstest: package testing/fstest is not in GOROOT (/usr/local/go/src/testing/fstest)
make: *** [Makefile:33: deps] Error 1

This appears to be related to this issue: golang/go#40067

The issue is solved by updating to use golang 1.16.

I also remove some obsolete replace directives that are fixed by upgrading.

cc @bhamail / @DarthHater

@bhamail bhamail requested a review from DarthHater March 22, 2021 17:41
@bhamail bhamail merged commit e6163ed into main Mar 22, 2021
@bhamail bhamail deleted the go_1.16 branch March 22, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant